Looping a call to a Modify__()

See if something like this works:

DECLARE

  info_ VARCHAR2(32000);
  attr_ VARCHAR2(32000);

  CURSOR get_data_ IS
    SELECT ip.part_no,
           ip.objid,
           ip.objversion
      FROM prd_08 p
     INNER JOIN inventory_part_planning ip
        ON p.part_no = ip.part_no
     WHERE p.contract = 'ABCD'
           AND p.part_no IN ('[a_bunch_of_Part_Numbers]')
     ORDER BY ip.part_no;

BEGIN

  client_sys.add_to_attr(name_ => 'SAFETY_LEAD_TIME', value_ => 5, attr_ => attr_);

  FOR rec_ IN get_data_
  LOOP
    info_ := null;

    inventory_part_planning_api.modify__(info_       => info_,
                                         objid_      => rec_.objid,
                                         objversion_ => rec_.objversion,
                                         attr_       => attr_,
                                         action_     => 'DO');

    COMMIT;
  END LOOP;
END;

Thanks guys, you really hit the nail on the head with your feedback. 

Out of curiosity (and since I see how @MatthewConk has suggested slight differences in code) I have this question. Is semantically equivalent to create the attr_ value using just as string “as in my case” or the add_to_attr function?

Do you see cases where add_to_attr not only is the “best practice” but delivers results than just crafting our attribute by constructing a string formatted the way it is expected by just assigning a string literal?

I really appreciate all the feedback, this community is VERY helpful!

@msurasky-price There is no real difference between your approach and using the add_to_attr method, so this should not have an impact on your code. 

PROCEDURE Add_To_Attr (
   name_  IN     VARCHAR2,
   value_ IN     VARCHAR2,
   attr_  IN OUT NOCOPY VARCHAR2 )
IS
BEGIN
   attr_ := attr_||name_||field_separator_||value_||record_separator_;
END Add_To_Attr;

I do it this way because I like cleaner code and I think it is easier to maintain this way. For one value it would not matter, but if you had twenty it could become harder to maintain/update. I want to make sure when I come back to it six or twelve months later it is easy for me to read, understand, and update. 

It matters even more if I have additional API calls to pull the value. This is a bad example because we would not need Payment Terms in Inventory Part Planning, but I think you will get what I am doing here:

  FOR rec_ IN get_data_
  LOOP
    info_ := null;
    client_sys.clear_attr(attr_ => attr_);

    client_sys.add_to_attr(name_ => 'SAFETY_LEAD_TIME', value_ => 5, attr_ => attr_);
    client_sys.add_to_attr(name_  => 'PAYMENT_TERMS',
                           value_ => identity_invoice_info_api.get_pay_term_id(company_   => rec_.company,
                                                                               identity_  => rec_.customer_id,
                                                                               party_type_  => 'CUSTOMER'),
                           attr_  => attr_);

    inventory_part_planning_api.modify__(info_       => info_,
                                         objid_      => rec_.objid,
                                         objversion_ => rec_.objversion,
                                         attr_       => attr_,
                                         action_     => 'DO');

    COMMIT;
  END LOOP;

No real difference in what is happening, just a different approach. 

Your explanation and example is super-clear @MatthewConk. Thanks for that!